Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call out v0 to v1 changes #1051

Closed
14 tasks done
stramel opened this issue Dec 11, 2017 · 2 comments
Closed
14 tasks done

Call out v0 to v1 changes #1051

stramel opened this issue Dec 11, 2017 · 2 comments

Comments

@stramel
Copy link
Contributor

stramel commented Dec 11, 2017

It would be nice to have linter warn and be able to fix some of the easy v0 to v1 spec changes with some Polymer changes that would allow Polymer v1 (P1) components to work with Polymer v2 (P2) legacy. These changes should allow P1 components to work with P2 without going into the full hybrid setup.

CSS

HTML

  • <content> to <slot> (Currently listed under Polymer)
    • Warns
    • Fixable
  • <style> tags moved inside <template>

Polymer

Possible Additional ones
Ensure semi-colon on CSS Mixin declarations
Polymer.dom returns NodeList instead of Array (NOTE: May be difficult to detect)
:host-context([dir=rtl])) to :dir(rtl) (NOTE: Only available in Firefox)
lazyRegister no longer exists (NOTE: Not sure this should be a lint rule)
this.customStyle['--my-toolbar-color'] = 'blue'; to this.updateStyles({'--my-toolbar-color': 'blue'});

@stramel
Copy link
Contributor Author

stramel commented Mar 7, 2018

This covers the majority of v0 to v1 changes.

@stramel stramel closed this as completed Mar 7, 2018
@rictic
Copy link
Contributor

rictic commented Mar 8, 2018

Awesome work @stramel!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants