Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prism on npm uses require, breaking prism-element #3273

Closed
rictic opened this issue Aug 23, 2017 · 2 comments
Closed

prism on npm uses require, breaking prism-element #3273

rictic opened this issue Aug 23, 2017 · 2 comments
Labels
Package: modulizer Priority: High Status: Available Type: Bug

Comments

@rictic
Copy link
Contributor

rictic commented Aug 23, 2017

The import is also wrong, similar to #174
@justinfagnani
Copy link
Contributor

I don't see that prism.js from npm uses require(). It looks like it'll write to window like we want.

@justinfagnani
Copy link
Contributor

Fixed by #328

@aomarks aomarks transferred this issue from Polymer/polymer-modulizer Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: modulizer Priority: High Status: Available Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rictic @aomarks @justinfagnani