Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wct] Child runners refactoring #394

Closed
merlinnot opened this issue May 16, 2018 · 1 comment · May be fixed by Exnadella/tools#88
Closed

[wct] Child runners refactoring #394

merlinnot opened this issue May 16, 2018 · 1 comment · May be fixed by Exnadella/tools#88

Comments

@merlinnot
Copy link
Contributor

I've spent a day trying to solve #229, but I find the code being too tightly coupled to make sure it works in all cases. There are two main reasons causing iframes not to be garbage collected:

  • attached event listeners
  • storing a reference to the same object in both outer and inner window

I've made a PR to fix the former, but the latter is much more complex due to data flying around both ways (shared state, error objects, statuses, ...). I feel like fixing the latter would require a deeper refactoring, preferably restricting all communication to postMessage and making it one-way only (like events).

What do you guys think? Maybe someone with a better understanding of a project would like to share some thoughts?

@merlinnot
Copy link
Contributor Author

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant