Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[analyzer] exclude life cycle methods (or make them "protected") #637

Closed
Scarygami opened this issue Aug 13, 2018 · 3 comments
Closed

[analyzer] exclude life cycle methods (or make them "protected") #637

Scarygami opened this issue Aug 13, 2018 · 3 comments
Labels

Comments

@Scarygami
Copy link

Life cycle methods like connectedCallback, disconnectedCallback etc. shouldn't show up as public methods in the element description.

"methods": [
  {
    "name": "connectedCallback",
    "description": "",
    "privacy": "public",
    ...
  }
]

They could probably be removed completely from the analyzer output, or at least marked as protected.

@43081j
Copy link
Contributor

43081j commented Aug 28, 2018

Seeing as they're technically public (nothing stopping you from el.connectedCallback()), we should probably just drop them.

If we agree on that I'm up for throwing up a quick PR for it.

@stale
Copy link

stale bot commented Mar 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 4, 2020
@stale
Copy link

stale bot commented Apr 28, 2022

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants