HTMLSplitter doesn't split script tags with the string "</script>"

[romaviolenta]

Hi,
I'm trying to build with js-minify e bundle enable, but in chrome console there is an error:

Uncaught SyntaxError: Invalid or unexpected token

This error is referred to this code :

if (this.myIFrame.src && "javascript:" === this.myIFrame.src.substr(0, "javascript:".length)) o = "<script>document.domain=\"" + document.domain + "\";</script>";

[keanulee]

I think HtmlSplitter/parse5 may be incorrectly splitting at the "</script>" string. Can you try to see what happens if you break up that string (e.g. "</scr"+"ipt>")?

[gilbertococchi]

Hi Keanu, you are right.
By splitting that way the Parser will no longer trigger the error.
Do you think we should open a pull request on htmlsplitter to change that?

[keanulee]

PR welcome, but given that we use parse5 for parsing, the fix will probably either need to be there or a re-implementation of parsing here. I don't think this issue a big priority for the team because inlining a script tag with HTML is unconventional.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.