Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parameterized NodeList to NodeListOf. #890

Closed
aomarks opened this issue Jan 8, 2018 · 0 comments
Closed

Rename parameterized NodeList to NodeListOf. #890

aomarks opened this issue Jan 8, 2018 · 0 comments
Assignees
@aomarks
Labels
Package: gen-typescript-declarations

Comments

@aomarks
Copy link
Member

aomarks commented Jan 8, 2018

Closure's !NodeList<!Element> is equivalent to TypeScript's NodeListOf<Element>. Same for HTMLCollection and HTMLCollectionOf. We need to rename those types when they are parameterized.

Depends on https://github.com/Polymer/gen-typescript-declarations/issues/58 for general support of type applications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aomarks aomarks

Labels
Package: gen-typescript-declarations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aomarks