-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove roboto dependency from paper-styles #128
base: master
Are you sure you want to change the base?
Conversation
The roboto font is a dependency on a hard-coded CDN. Applications can add the dependency and include the font as needed, rather than rely paper-styles, which is used extensively throughout the Polymer components. This is similar to other fonts listed in default styles that might not be available on a system by default, but can be resolved externally at the application level. This change does not provide backward compatibility or a deprecation period.
I'm submitting this as a proposal. It address #22 and #111. For some reason #22 was closed as being fixed by #44 - but I'm not seeing how that PR addresses this issue. Listing Roboto as a default font is benign. Hard coding the font dependency on an external CDN is not. It's common enough to list fonts that may not be available on a system, finally specifying default fonts like "sans serif", "mono" etc as fall backs. There's no reason to enforce downloading a font from an external site. If the user wants the font, she can resolve the dependency at the application level. |
Paper-styles must use font-roboto-local because polymer-build doesn't bundle it Polymer/polymer-build#155 |
Use this repo https://github.com/StartPolymer/paper-styles-plus ;-) |
Does any news regarding this issue? But I guess the dependency should be replace by this module : So do you know the best way to remove the dependency to the fonts.googleapis.com request ? Thanks |
2019 here, this is still an issue. Lighthouse gives me a failed report because of this. can we think of removing this or making it compatable with font-display: swap? |
@quetzalsly : See the source code from PolymerElements/font-roboto : Hope it's what you are looking for. |
The roboto font is a dependency on a hard-coded CDN. Applications can
add the dependency and include the font as needed, rather than rely
paper-styles, which is used extensively throughout the Polymer
components. This is similar to other fonts listed in default styles
that might not be available on a system by default, but can be
resolved externally at the application level.
This change does not provide backward compatibility or a deprecation
period.