-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship update in sync with MySqlConnector 0.57.0 #794
Comments
@caleblloyd If I made a commit based on c58e00c that updated MySqlConnector and set the version to 2.2.1, would you be OK with shipping that (and be able to)? |
@bgrainger yes, I could do that! |
@caleblloyd It looks like commits on the The tip of that branch should be ready to publish as v2.2.1 (mostly just an update to MySqlConnector 0.57.0); what's the best way to get it published? |
@caleblloyd Are we waiting on changes in #824 (comment) before a 2.2.1 package can be published? (No hurry, just making sure I understand the plan.) |
Sorry missed these comments. 2.2.6 work superceded 2.2.1 before it was released, and 2.2.6 is now published |
2.2.6 has solved this problem (and no one complained about a binary ABI incompatibility anyway...). |
In mysql-net/MySqlConnector#642, I am implementing some new "Async" methods that are coming in .NET Core 3.0.
I'd also like to change the method definitions of some existing async methods to be consistent with .NET Core 3; however, this will be a breaking change. (It's currently in beta, and hasn't shipped in a stable release.)
I think this can be mitigated if an update to Pomelo.EntityFrameworkCore.MySql that depends on MySqlConnector 0.57.0 is shipped as soon as MySqlConnector 0.57.0 is available.
Is it possible that you would be able to ship 2.2.1 (or 2.3.0?) with this updated dependency and we could synchronise ship dates? There are no source-breaking changes; the code of 2.2.0 just needs to be recompiled against an updated MySqlConnector.
The text was updated successfully, but these errors were encountered: