Pulseaudio: Add function to handle Pulseaudio pa_operation #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illuusio
changed the title
illuusio
force-pushed
the
update-macro-defs
branch
2 times, most recently
from
7272950 to
f6a745a
Compare
|
There does not appear to be a reason for this to be a macro, could you make it a regular function please? |
illuusio
force-pushed
the
update-macro-defs
branch
from
f6a745a to
d8026fb
Compare
illuusio
changed the title
|
Ok I've reworked macro to function and made needed changes to code. |
illuusio
force-pushed
the
update-macro-defs
branch
from
d8026fb to
c381e43
Compare
RossBencina
requested changes
Jun 28, 2024
philburk
reviewed
Jun 28, 2024
RossBencina
added
the
src-pulseaudio
|
@philburk this could be reviewed again is it ok to merge |
illuusio
force-pushed
the
update-macro-defs
branch
from
7214007 to
80b3257
Compare
|
Ok I fixed some locking problem which was caused when stopping device but now it does not hang because of double locking. |
illuusio
force-pushed
the
update-macro-defs
branch
from
80b3257 to
5715e73
Compare
RossBencina
reviewed
Sep 13, 2024
philburk
approved these changes
Sep 26, 2024
Now pa_operation are handled multiple ways. Add function to make sure that they are handled always same.
As function does not return value it should be void type Co-authored-by: Ross Bencina <rossb@audiomulch.com>
As function does not return value it should be void type Co-authored-by: Ross Bencina <rossb@audiomulch.com>
…_wait Mainloop should be locked when using pa_threaded_mainloop_wait make changes that it happens
illuusio
force-pushed
the
update-macro-defs
branch
from
5715e73 to
cdde14d
Compare
RossBencina
approved these changes
Oct 3, 2024
philburk
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies handling on pa_operation. It does not add or remove anything just adds function that should make easier not to get into infinite loop at the start.