wasapi: Workaround for the Realtek driver "Mono" bug

[dmitrykos]

Workaround for the Realtek driver bug when driver mistakenly accepts Mono format with IAudioClient_IsFormatSupported() while subsequently fails in IAudioClient_Initialize().

It is a long-lasting issue #875 which was resolved with a kind debugging help by @arkadijs.

Closes #875.

[arkadijs]

Confirming, this fixes the issue with the buggy? Realtek driver.

[dmitrykos]

@arkadijs thank you very much for testing. Now let's wait for a review from @RossBencina and @philburk to get this PR approved.

[RossBencina]

I have not tested it, but it looks OK. my main concern would be whether this could introduce a regression on other drivers. is it passing the PortAudio pa_loopback tests?

[dmitrykos]

I have not tested it, but it looks OK. my main concern would be whether this could introduce a regression on other drivers. is it passing the PortAudio pa_loopback tests?

Great that you mentioned it! I modified workaround to exclude Input mode as this driver bug is related to Output only.

As to pa_loopback - it fails for WASAPI on [Loopback] device because of this #935 issue - when there is no audio sent to WASAPI internal mixer from some opened audio streams the attempt to read data from [Loopback] device will timeout i.e. PaQa_RunInputOnly() fails. But it has nothing to do with workaround of this PR - tested.

I propose to discuss the timeout of [Loopback] WASAPI device in #935, there we can also discuss whether a workaround needed in pa_loopback implementation for loopback devices which timeout without audio data collected from other opened audio streams, or perhaps PA WASAPI needs some workaround for this specific behavior.

This PR looks ok for me to commit.

[arkadijs]

There is one problem with the latest version though: output == 0 thus workaround never activates.

Removing if (output && allows recording to proceed. Added some printf calls for debug:

device name: Słuchawki (Realtek(R) Audio) [Loopback]; hr = 1; output = 0
device name: Słuchawki (Realtek(R) Audio) [Loopback]; hr = 1; output = 0
device name: Słuchawki (Realtek(R) Audio) [Loopback]; hr = 1; output = 0
device name: Słuchawki (Realtek(R) Audio) [Loopback]; hr = 1; output = 0
device name: Słuchawki (Realtek(R) Audio) [Loopback]; hr = 0; output = 0
should we try Realtek workaround?
activating Realtek workaround
Słuchawki (Realtek(R) Audio) [Loopback]: trying callback API...
device name: Słuchawki (Realtek(R) Audio) [Loopback]; hr = 0; output = 0
should we try Realtek workaround?
activating Realtek workaround
Słuchawki (Realtek(R) Audio) [Loopback]: stream active: 1
Słuchawki (Realtek(R) Audio) [Loopback]: success

[arkadijs]

Another issue: callback API works perfectly but sync Pa_ReadStream() produces grabled audio which is recognizable yet sounds like a wrong format, clipped? or bad interleave. Sample rate and length of the audio are correct. Capturing mic with sync API works.
Please let me know if you need the output sample or any additional debug info.

[dmitrykos]

@arkadijs thank you very much for testing again, that was typo on my side. I modified that check to !output to limit the case only to capturing devices:

        if (!output && isSharedMode && (params.channelCount == 1) && (sharedClosestMatch == NULL) &&
            (deviceInfo->MixFormat.Format.nChannels > 1))

Would you please double check if it still works well for you to double confirm.

callback API works perfectly but sync Pa_ReadStream() produces grabled audio which is recognizable yet sounds like a wrong format, clipped?

I managed to reproduce it by modifying paex_read_write_wire.c example which reads Loopback and writes to Speakers. I used Speakers for listening and USB DAC for playing to it with another app. It is not related to the workaround of this PR though and is an old bug. I propose to open new issue which we will close with a new PR related to this issue. Would you please open it as long as you initially found and reported this problem.

[arkadijs]

Tested latest version with !output and it works for me. Thanks!

Opened #945.

[dmitrykos]

Tested latest version with !output and it works for me. Thanks!

Great! Lets wait for @RossBencina to resolve his question.

[RossBencina]

I'll merge this once CI passes

[arkadijs]

GHA had issues yesterday, please bump the jobs bumped to clear CI.

[dmitrykos]

@RossBencina I merged it for you, if you do not mind, so we could go forward with other fixes.