undo .def file ordinal change made in 605fc89. … #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBencina
changed the title
…end-only policy for ordinal changes. resolves PortAudio#784
RossBencina
force-pushed
the
784_revert_def_file_ordinal_change_add_comment
branch
from
e57526b to
900ab94
Compare
philburk
approved these changes
Jul 12, 2024
|
@dmitrykos ok with you? |
|
@dmitrykos awaiting your review |
dmitrykos
approved these changes
Aug 2, 2024
@RossBencina I am really sorry, missed your question! The change is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add comments about append-only policy for ordinal changes. resolves #784
here's the change that it undoes: 605fc89
Phil and I have decided that we prefer this to #941