Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: const defaultHost was renamed to DEFAULT_HOST and broke the Android build #98

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix: const defaultHost was renamed to DEFAULT_HOST and broke the Android build #98

merged 2 commits into from
Apr 11, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Apr 11, 2024 •
edited
Loading

💡 Motivation and Context

Fixes #96

💚 How did you test it?

CI is green

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto mentioned this pull request Apr 11, 2024
Closed
4 tasks
@marandaneto marandaneto marked this pull request as ready for review April 11, 2024 11:46
@marandaneto marandaneto requested a review from a team April 11, 2024 11:46
@marandaneto marandaneto merged commit 8457972 into main Apr 11, 2024
8 checks passed
@marandaneto marandaneto deleted the fix/default-host branch April 11, 2024 11:58
@zharfan104
Copy link

zharfan104 commented Apr 12, 2024 •
edited
Loading

Thanks for this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradle build failing due to missing PostHogConfig.defaultHost
2 participants
@marandaneto @zharfan104