Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Custom Placeholder Text in Laravel Livewire Power Grid Number Filter #1534

Closed
moxesh-easternts opened this issue May 7, 2024 · 1 comment

Comments

@moxesh-easternts
Copy link

⚡ PowerGrid ⚡ Feature Request

Summary

I'm requesting the ability to set custom placeholder text for the min and max input boxes in the Laravel Livewire PowerGrid's number filter.

Why is this needed?

Currently, when using multiple instances of Filter::number, it can be confusing for users to see "Min" and "Max" placeholders repeated. This confusion can be alleviated by allowing developers to specify custom placeholder text for each instance of the number filter.

Suggested Solution(s)

I suggest enhancing the PowerGrid component to support custom placeholder text for each Filter::number instance. However, it appears that there might be an issue with the chaining of methods for setting the placeholder text, as demonstrated in the following code:

Filter::number('earn_point', 'earn_point')
    ->thousands(',')
    ->placeholder('Minimum Earning Point', 'Maximum Earning Point'),

Related issue(s)/PR(s)

This request is not related to any existing issue or pull request.

@dansysanalyst
Copy link
Member

Hi @moxesh-easternts,

Thank you for submitting the feature request.

The ->placeholder() method already exists, but it is not working. I will be submitting a PR soon.

I am closing this issue in favor of the bug report issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants