PSAvoidTrailingWhitespace: Rule not applied when using formatter + single character lines with trailing whitespace are truncated #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dered by the formatter
…character, followed by multiple white-spaces were truncated when fixed/formatted
…ormatter with PSAvoidTrailingWhitespace and also checking that single-character lines that have trailing whitespace are not removed
liamjpeters
changed the title
Ju-l1a
approved these changes
Apr 15, 2024
|
I don't know if this is to do with this issue specifically but I've found that with this branch the fix for Edit: actually I'm getting the same for |
|
Hey @Ju-l1a 👋, You need to tell the formatter to include that rule when carrying out the formatting. $Settings = @{
IncludeRules = @("PSAvoidTrailingWhitespace")
Rules = @{
"PSAvoidTrailingWhitespace" = @{}
}
}So the below code, with lots of trailing whitespace: $ScriptDef = @"
Function Get-Example {
'Example'`t`t`t
}`t`t`t
"@Is not altered when running: Invoke-Formatter -ScriptDefinition $ScriptDef
But is fixed when running: Invoke-Formatter -ScriptDefinition $ScriptDef -Settings $Settings
Hope that helps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Added
PSAvoidTrailingWhitespaceto the list of rules considered by the formatter (an entry for the rule is still required in theRulespart ofsettings).Fixes The PSAvoidTrailingWhitespace rule is not applied when using Invoke-Formatter #1992
Fixed an issue where lines starting with and containing a single character, that have trailing white-space, are truncated when formatted/fixed. See comment in #1992 for explanation.
Fixes Fixing PSAvoidTrailingWhitespace is broken #1757
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.