Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revamp pipeline thread handling] Re-enable PS event handling #1433

Closed
SydneyhSmith opened this issue Mar 29, 2021 · 2 comments
Closed

[Revamp pipeline thread handling] Re-enable PS event handling #1433

SydneyhSmith opened this issue Mar 29, 2021 · 2 comments
Labels
Area-Engine Issue-Bug A bug to squash.

Comments

@SydneyhSmith
Copy link
Collaborator

SydneyhSmith commented Mar 29, 2021

Currently, PSES manages its events through PSRL's PS event handling functionality, which is here.

When PSRL idles, we run PowerShell events. And in fact today's PSES adds its own events to the event handler -- it's where the extension runs all its PowerShell executions for services. Which leads to issues like PowerShell/vscode-powershell#2448.

With the async pipeline thread consumer, we are now in control of all of this, but we lose PSRL's handling of it.

We either need to:

  • Work out a way to get PSRL to handle it again, or
  • Handle it ourselves

We have to remember that events can only be processed in a nested PowerShell.

The assumption currently is that we'll handle things ourselves and do it here:

@ghost ghost added the Needs: Triage Maintainer attention needed! label Mar 29, 2021
@SydneyhSmith SydneyhSmith added Area-Engine Issue-Bug A bug to squash. and removed Needs: Triage Maintainer attention needed! labels Mar 29, 2021
@rjmholt
Copy link
Contributor

rjmholt commented Oct 11, 2021

To solve in #1459

@rjmholt
Copy link
Contributor

rjmholt commented Oct 28, 2021

Fixed in #1581. See #1591

@rjmholt rjmholt closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Engine Issue-Bug A bug to squash.
Projects
None yet
Development

No branches or pull requests

2 participants