Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hovering function name highlights definition #1888

Closed
3 tasks done
fflaten opened this issue Aug 14, 2022 · 0 comments · Fixed by #1890
Closed
3 tasks done

Hovering function name highlights definition #1888

fflaten opened this issue Aug 14, 2022 · 0 comments · Fixed by #1890

Comments

@fflaten
Copy link
Contributor

fflaten commented Aug 14, 2022

Prerequisites

  • Write a descriptive title.
  • Make sure you are able to repro it on the latest version
  • Search the existing issues.

Steps to reproduce

Create a function, hover the name and notice the highlighting

Expected behavior

Highlights only function name (symbol), to be consistent with other languages.

Highlighting calls the AST visitor with includeFunctionDefinitions: false which should mean it should be excluded per documentation

/// <param name="includeFunctionDefinitions">Includes full function definition ranges in the search.</param>

Actual behavior

Highlights function name and scriptblock, even though keyword is excluded.

Error details

No response

Environment data

Name                           Value
----                           -----
PSVersion                      7.2.6
PSEdition                      Core
GitCommitId                    7.2.6
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Version

2022.8.2 preview

Visuals

PowerShell function:
image

C# method:
image

TypeScript method:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants