Increase connection timeout #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Aug 15, 2018
src/utils.ts
Outdated
| // Try once per second for 60 seconds, one full minute | ||
| innerTryFunc(60, 1000); | ||
| // Try once every 2 seconds for 120 seconds, two full minutes | ||
| innerTryFunc(120, 2000); |
There was a problem hiding this comment.
Doesn't this bump the max wait time to 4 mins? 2 * 120 secs. Maybe just use (120, 1000)?
There was a problem hiding this comment.
Good point. I'm thinking it should be 60, 2000 maybe? Ideally this should be exponential backoff style perhaps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Resolves #1360.
Increases the connection timeout to 2 minutes, while making it check only once every 2 seconds.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready