Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ShowOnlineHelp Command #1587

Merged
merged 2 commits into from
Oct 18, 2018
Merged

Removed ShowOnlineHelp Command #1587

merged 2 commits into from
Oct 18, 2018

Conversation

corbob
Copy link
Contributor

@corbob corbob commented Oct 17, 2018

PR Summary

Remove the ShowOnlineHelp command from the Command Palette.

Command was deprecated in 1.9.0. This is to fully remove the command.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rkeithhill
Copy link
Contributor

You might as well remove the PowerShell.OnlineHelp from the Commands array in package.json.

@rjmholt rjmholt merged commit d246b9f into PowerShell:2.0.0 Oct 18, 2018
rjmholt pushed a commit to rjmholt/vscode-powershell that referenced this pull request Nov 30, 2018
* Removed ShowOnlineHelp Message

* Remove the command element from package.json
rjmholt pushed a commit to rjmholt/vscode-powershell that referenced this pull request Nov 30, 2018
* Removed ShowOnlineHelp Message

* Remove the command element from package.json
@corbob corbob deleted the RemoveOnlineHelp branch January 17, 2019 04:58
rjmholt pushed a commit to rjmholt/vscode-powershell that referenced this pull request Jan 18, 2019
* Removed ShowOnlineHelp Message

* Remove the command element from package.json
rjmholt pushed a commit to rjmholt/vscode-powershell that referenced this pull request Jan 18, 2019
* Removed ShowOnlineHelp Message

* Remove the command element from package.json

[Ignore] Fix typo in package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants