Set featureFlag default to null so that it can be resolved by settings #1838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So we are still only enabling PSRL by default on Windows? Sorry, haven't been using VSCode and the extension of Linux much lately. Is there a problem with PSRL on Linux/macOS? |
|
It's a problem with PSES + PSRL on Linux/MacOS. Unfortunately, due to differences in System.Console API's and some threading issues, with PSRL enabled on unix, it holds on to the pipeline thread meaning no editor features at all :( |
|
Bummer! |
|
These tests should probably be fleshed out to make sure they're set to what we expect... but I'll call that out of scope for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This will properly enable PSReadLine by default because the setting will be resolved by the extension here. Something tells me I had this set, but didn't actually commit it... 😅
fixes #1822
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready