Add powershell version telemetry #1908
Conversation
|
Ok I've moved the location of the telemetry call to where @rkeithhill suggested. That's definitely the right place! |
|
The one thing I'm not too sure about is how to stop debug builds from sending telemetry. Maybe it's just such a small number that it doesn't matter? Thoughts? |
|
I think it's probably too insignificant to care about, but otherwise the server can use The problem is getting that information in the client, which I think could only be achieved by either querying (or being sent at startup) information from the server, or if the client itself is built with a debug flag. It's probably too much work to be worth it at this stage, but would be worth adding with greater investment later. |
|
@rjmholt |
|
Isn't there a VSCode API to see if you're running in the extension dev host? |
No, only server-side — in PSES |
|
@rkeithhill without doing something tricky like checking the file path, there doesn't seem to be a way to do that, unfortunately. |
|
Could you check the app title bar to see if it contains "Extension Development Host"? |
|
Naturally David thought about this and a mechanism already existed :) |
|
That VSCode issue is still open almost three years later. :-( You guys should vote it up. |
PR Summary
Leveraging the vscode-extension-telemetry extension, this adds a single additional data point... "PowerShell version". This helps us answer the question:
"Who is using VSCode?
Is it Windows PowerShell, PowerShell Core?
Is anyone on v3/v4 using the stable version right now?"
This means we can better focus our efforts in developing and maintaining the PowerShell extension.
This node module honors the vscode mechanism for opting out of telemetry so we do not need to add any custom logic for that scenario.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready