don't delete the session file #2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Oct 2, 2019
|
It is a concern but I don't really have time to implement it properly (hence the TODO in the comment) :( - and restart working 98% of the time is better than 0%. |
rjmholt
approved these changes
Oct 2, 2019
|
Also, wouldn't the new process of the same pid create a new session file? Unless the same pid can be used by the same process, I don't see this being an issue. |
rkeithhill
approved these changes
Oct 2, 2019
True dat! |
TylerLeonhardt
added a commit
that referenced
this pull request
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
fixes #2144
Rob's comment gave it a way. Restart was totally broken and I opened an issue on vscode about this behavior.
I'm not sure they'll fix it so we'll go with this workaround for now...
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready