-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface Invoke Registered Editor Command #2225
Surface Invoke Registered Editor Command #2225
Conversation
This commit allows the `PowerShell.InvokeRegisteredEditorCommand` command to be accessible to the user in the Command Palette.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Gosh I love json-only changes that expose new features
I see two approvals for this, is there anything waiting on me to do to get this merged? |
Thank you for your contribution! So many people have asked for this! 🎉 |
This commit allows the `PowerShell.InvokeRegisteredEditorCommand` command to be accessible to the user in the Command Palette.
}, | ||
{ | ||
"command": "PowerShell.InvokeRegisteredEditorCommand", | ||
"when": "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerLeonhardt As far as I can tell this means that the command will never be shown in the command palette...so this PR didn't do what it intended. 🧐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @rjmholt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerLeonhardt As far as I can tell this means that the command will never be shown in the command palette...so this PR didn't do what it intended. 🧐
I believe it's just the description that is off. This PR enabled it's usage in keybinds, e.g. this failed before it:
{
"key": "alt+shift+s",
"command": "PowerShell.InvokeRegisteredEditorCommand",
"args": { "commandName": "ConvertTo-SplatExpression" },
"when": "editorLangId == 'powershell'"
},
Since it has parameters, and "Show Additional Commands from PowerShell Modules" fills the command palette role, I believe this was intended.
PR Summary
This commit allows the
PowerShell.InvokeRegisteredEditorCommand
command to be accessible to the user in the Command Palette.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.NA
WIP:
to the beginning of the title and remove the prefix when the PR is readyFixes #2145