Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start EditorServices without start script #2348

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Dec 6, 2019

Targets changes in PowerShell/PowerShellEditorServices#1118.

Rather than starting with Start-EditorServices.ps1, we now import the module and invoke the binary cmdlet directly. So no need for script execution for startup.

PSES still has the startup script to enable other clients to continue using the original API.

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjmholt rjmholt merged commit 5a4e111 into PowerShell:master Dec 10, 2019
@rjmholt rjmholt deleted the binary-module-start branch December 11, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants