Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding configuration to logs #1393

Open
rjmholt opened this issue Jun 29, 2018 · 3 comments
Open

Add encoding configuration to logs #1393

rjmholt opened this issue Jun 29, 2018 · 3 comments
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).

Comments

@rjmholt
Copy link
Contributor

rjmholt commented Jun 29, 2018

Not sure if we already do this or if it's possible, but we've had a few issues to do with encoding.

Ideally that information should just be in the logs.

Specifically we should add:

  • The "files.encoding" to the VSCode extension logs
  • PowerShell's $OutputEncoding (and possibly others) to the EditorServices logs

Thoughts? Any other suggestions?

@rjmholt rjmholt added Issue-Enhancement A feature request (enhancement). Area-Logging labels Jun 29, 2018
@rjmholt rjmholt self-assigned this Aug 24, 2018
@rjmholt
Copy link
Contributor Author

rjmholt commented Oct 12, 2018

Also add the full version (+ prerelease suffix) in the log file (PowerShell/PowerShellEditorServices#770).

@rjmholt
Copy link
Contributor Author

rjmholt commented Oct 15, 2018

It looks like getting VSCode's file encoding configuration may not currently be possible: microsoft/vscode#824

@rjmholt rjmholt removed their assignment Oct 29, 2018
@rjmholt
Copy link
Contributor Author

rjmholt commented Oct 29, 2018

Unassigning myself since I've done all the work I think that can be done on this for the moment.

Leaving the issue open to track adding in VSCode's encoding configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

1 participant