Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a search field for the "Powershell Command Explorer". #1656

Closed
ChadThomsen opened this issue Dec 13, 2018 · 17 comments
Closed

Add a search field for the "Powershell Command Explorer". #1656

ChadThomsen opened this issue Dec 13, 2018 · 17 comments
Labels
Area-Command Explorer Feature: VS Code Request to use or implement a VS Code feature. Issue-Enhancement A feature request (enhancement).

Comments

@ChadThomsen
Copy link

Summary of the new feature
Would be nice to have a field just below the title bar that is a search field. That way you could put in a string of characters and only commands that match the string you are searching for would show up in the command explorer. I do like the Command Explorer as that is a nice feature! Keep up the good work.

Proposed technical implementation details (optional)

A clear and concise description of what you want to happen.

@TylerLeonhardt
Copy link
Member

Glad you like it!

vscode would have to provide us a mechanism for a search box or we'd have to do a lot of additional work to get something kind of working...

that said... one of the folks on the vscode team hinted at such a feature on Twitter:
https://twitter.com/joaomoreno/status/1073107112702685184

So for us, it's probably best we wait and see what that team does and then we get it for free/little effort 😄

@TylerLeonhardt TylerLeonhardt added Issue-Enhancement A feature request (enhancement). Feature: VS Code Request to use or implement a VS Code feature. Area-Command Explorer labels Dec 13, 2018
@corbob
Copy link
Contributor

corbob commented Dec 13, 2018

There's a vscode issue tracking this as well: microsoft/vscode#50062

@moymike
Copy link

moymike commented Jan 21, 2019

The "Todo Tree" extension does it by using a 'filter' icon on it's panel that activates the main input box in the top center on vscode.

@TylerLeonhardt
Copy link
Member

We're going to get a filter feature very soon:

https://twitter.com/joaomoreno/status/1087365894983073793?s=19

So it might not be worth investing too much time in a custom solution. 😊

@superfliege
Copy link

+1 realy need this feature. It should also not be too hard to implement this. Thanks guys!

@corbob
Copy link
Contributor

corbob commented Jun 4, 2019

+1 realy need this feature. It should also not be too hard to implement this. Thanks guys!

I don't think it's quite as simple to implement as you're implying. It also might not be worth investing too much time in a custom solution if vscode is working to include the functionality for us.

That being said, if I determine I have the time, I might take a stab at something like what @moymike noted in using a filter through input box.

@superfliege
Copy link

@corbob I do not know your code structure, but adding a textbox that filters a ListView should not be that hard.

Do not get me wrong. I'm sure you're doing a good job and I'm happy about this upcoming feature.

@rjmholt
Copy link
Contributor

rjmholt commented Jun 5, 2019

I do not know your code structure

Indeed.

The extension doesn't have direct control of the UI; it uses a VSCode API called Tree View which we use here. It just takes data and displays it, so there's no way to alter the UI to include a filter.

There's an outstanding feature request to add a filter functionality to APIs like this in VSCode and, as @TylerLeonhardt said, it looks like the VSCode team are looking to implement it.

@goyzhang
Copy link

The type-and-navigate feature has been added microsoft/vscode#10026
Is it possible to adapt it to this extension?

@dahifi
Copy link

dahifi commented Jul 19, 2019

I consider the PS command explorer essential for working in the ISE. Since it's been abandoned by MS, it would be nice if VSCode could implement this....

@corbob
Copy link
Contributor

corbob commented Jul 19, 2019

I consider the PS command explorer essential for working in the ISE. Since it's been abandoned by MS, it would be nice if VSCode could implement this....

This is definitely being worked on. As @rjmholt mentioned there's an outstanding feature request with vscode to ad a filter functionality. As of June 5th this was still planned, just delayed: https://twitter.com/CoryKnox/status/1135945751509504000 As for what @goyzhang mentioned, I haven't seen the type-and-navigate, so I don't know how difficult it might be for adapting to the TreeView.

@TylerLeonhardt
Copy link
Member

@joaomoreno for visibility

@joaomoreno
Copy link

This is already implemented in Insiders using the new tree's highlight/filter functionality. Just start typing when focused in the tree. microsoft/vscode#63566

@corbob
Copy link
Contributor

corbob commented Jul 23, 2019

Can confirm this is working for me in insiders. 😍
TreeViewTypeToHighlight

Guess this means I need to get #1972 done so that this can be even more useful...

@TylerLeonhardt
Copy link
Member

Awesome! I'm going to go ahead and close this issue since it's in insiders. Let me know if anyone feels otherwise

@filippobottega
Copy link

In my opinion type-and-navigate is not so useful because a filter is better. If you need to search "Item" for example, you can't find Get-Item, the only result is the first command with "I" as first character. Definitely not useful to search.

Thank you for your support,
Filippo

@moymike
Copy link

moymike commented Oct 16, 2024

Yes, a "filter" would be much more useful. Filter "item" and narrow down the list to just the commands that contain "item".
(I'm sure there are better examples...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Command Explorer Feature: VS Code Request to use or implement a VS Code feature. Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests