Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline should also support #Region #3604

Closed
2 tasks done
emrgcl opened this issue Oct 5, 2021 · 2 comments · Fixed by PowerShell/PowerShellEditorServices#2003
Closed
2 tasks done

Outline should also support #Region #3604

emrgcl opened this issue Oct 5, 2021 · 2 comments · Fixed by PowerShell/PowerShellEditorServices#2003
Labels
Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@emrgcl
Copy link

emrgcl commented Oct 5, 2021

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

Outline pane in vscode should also include / support #region blocks in Powershell.

Outline is a great tool for navigating hundreds of lines. If there are hundred of lines the Powershell Developer utilises region of code blocks using the #region / #endregion blocks to navigate easier. If this is implemented in the outline it will add a lot value to the PowerShell developer.

Proposed Design

No response

@emrgcl emrgcl added the Issue-Enhancement A feature request (enhancement). label Oct 5, 2021
@ghost ghost added the Needs: Triage Maintainer attention needed! label Oct 5, 2021
@andyleejordan
Copy link
Member

Oh that's a great idea! Do you know what it would look like? I'm going to mark this as up for grabs because I'd happily take a PR that enabled it, but am unsure of when I'd be able to get to it myself.

@andyleejordan andyleejordan added Up for Grabs Will shepherd PRs. and removed Needs: Triage Maintainer attention needed! labels Oct 5, 2021
@andyleejordan andyleejordan added this to the Consider-vNext milestone Oct 5, 2021
@glennsarti
Copy link
Contributor

Hi @emrgcl and @andschwa. AFAIK the outline view actually comes from the Document/Symbol request to the PowerShell Editor Services. I think it would be possible to add this for regions (I actually implemented the code-folding for regions previously) using the existing token operations code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
4 participants