Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency vscode-languageclient bumped VS Code requirement to v1.82 #4762

Closed
4 of 6 tasks
coolhome opened this issue Sep 29, 2023 · 5 comments · Fixed by #4763
Closed
4 of 6 tasks

Dependency vscode-languageclient bumped VS Code requirement to v1.82 #4762

coolhome opened this issue Sep 29, 2023 · 5 comments · Fixed by #4763
Assignees
Labels

Comments

@coolhome
Copy link

coolhome commented Sep 29, 2023

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

Terminal never fully loaded. Downgrading back down to 2023.9.2

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.3.6
PSEdition                      Core
GitCommitId                    7.3.6
OS                             Microsoft Windows 10.0.22621
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Visual Studio Code Version

1.81.1
6c3e3dba23e8fadc360aed75ce363ba185c49794
x64

Extension Version

ms-vscode.powershell@2023.9.3

Steps to Reproduce

Install preview extension - however there may be more here I am unable to find.

Visuals

image
image

This is where its stuck. Downgrading resolved the issue.

Logs

No response

@coolhome coolhome added the Issue-Bug A bug to squash. label Sep 29, 2023
@andyleejordan
Copy link
Member

Hi,

Could you please provide more logging and environment information by following these steps?

Thanks!

@coolhome
Copy link
Author

@andyleejordan Enabling diagnostic on the Language Server produced the root issue.

The language client requires VS Code version ^1.82.0 but received. 1.81.1

Upgraded to 1.82.2 and it's working again. I'm surprised there was no alert for this.

@andyleejordan
Copy link
Member

andyleejordan commented Sep 29, 2023

I...did not know it would bump that requirement! That's extremely good information. I should have looked at #4757 closer (which I assume has to be the dependency that bumped that up)...not that doing so would have done any good, I can't see anywhere that requirement is called out.

@andyleejordan andyleejordan pinned this issue Sep 29, 2023
@andyleejordan
Copy link
Member

I had to dig a bit and it is indeed that package (or set of packages) as I see it updated in microsoft/vscode-languageserver-node#1312 but yeah, no mention in changelog. I'll downgrade the package and make a note of that.

@andyleejordan andyleejordan reopened this Sep 29, 2023
@andyleejordan andyleejordan changed the title v2023.9.3-preview - Terminal not fully booted Dependency vscode-languageclient bumped VS Code requirement to v1.82 Sep 29, 2023
@andyleejordan andyleejordan self-assigned this Sep 29, 2023
@andyleejordan andyleejordan moved this to In Progress in Flying Fox Sep 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Flying Fox Sep 29, 2023
@andyleejordan
Copy link
Member

Thanks again @coolhome. Just released v2023.9.4-preview after verifying the extension would start up with VS Code v1.79 (our minimum requirement). Cheers!

@andyleejordan andyleejordan unpinned this issue Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants