Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xCluster`s Get function will fail #28

Closed
sosato opened this issue Nov 3, 2016 · 3 comments · Fixed by #113
Closed

xCluster`s Get function will fail #28

sosato opened this issue Nov 3, 2016 · 3 comments · Fixed by #113
Labels
bug The issue is a bug.

Comments

@sosato
Copy link

sosato commented Nov 3, 2016

xCluster module`s get function will fail, due to using Get-ClusterGroup Cmdlet.

$address = Get-ClusterGroup -Cluster $Name -Name "Cluster IP Address" | Get-ClusterParameter "Address"

"Cluster IP Address" is not Cluster Group, it is Cluster Resource. We should use Get-ClusterResource Cmdlet.
@johlju
Copy link
Member

johlju commented Nov 3, 2016 •
edited
Loading

You are correct. I verified this. I think the Get-ClusterResource has 'fallen out' of the code :/
I think it meant to be like this.

Get-Cluster -Name 'MyCluster' |
    Get-ClusterResource -Name 'Cluster IP Address' |
        Get-ClusterParameter 'Address'

That will return the IP-address.

@johlju
Copy link
Member

johlju commented Nov 3, 2016

This bug was introduced in PR #22. Get-ClusterResource was remove (by mistake), and it was apparently not caught by review or by tests.
https://github.com/PowerShell/xFailOverCluster/pull/22/files#diff-8b089640da31e97f466dca5697c68d6dL39

@johlju
Copy link
Member

johlju commented Nov 3, 2016

This is already being worked on in PR #25

@johlju johlju added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels Jun 8, 2017
@wasabii wasabii mentioned this issue Dec 22, 2017
Merged
5 tasks
johlju pushed a commit that referenced this issue Dec 22, 2017
@wasabii @johlju
xCluster: Allow cluster to be assigned IP address from a DHCP (#113)
3c95d26 
- Changes to xCluster
  - Allow the cluster to be assigned an IP address from a DHCP (issue #109).
    When the parameter StaticIPAddress is not specified then the cluster will be
    configured to use an IP address from a DHCP.
  - Get-TargetResource now correctly returns the IP address instead of throwing
    and error (issue #28).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xCluster: Allow cluster to be assigned IP address from a DHCP
2 participants
@sosato @johlju