-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[agent] chart overhaul #45
Conversation
@@ -1 +1 @@ | |||
1. Check Prefect agent connections in the prefect UI at {{ .Values.config.apiUrl }} | |||
1. Check Prefect agent connections in the prefect UI at {{ .Values.agent.config.apiUrl }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't need to be in this PR, but should we have a more comprehensive notes file, since this is shown whenever helm install
or helm upgrade
finishes?
@@ -80,7 +80,7 @@ postgresql: | |||
# when using the Postgres database included in the chart. | |||
# For an external postgres connection, you must create | |||
# and use `existingSecret` instead of `postgresqlPassword`. | |||
# password: "HEREWEGO" | |||
password: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncommenting this by default to grant it better visibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
FYI relevant kube lint flagged issues below. Unfortunately we cannot set container security context as the prefect image expects the agent to run as the root user, otherwise it is unable to create the
|
This PR rebuilds the prefect-agent chart using bitnamis common as its base.
Related to #44