Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent] chart overhaul #45

Merged
merged 34 commits into from
Sep 21, 2022
Merged

[agent] chart overhaul #45

merged 34 commits into from
Sep 21, 2022

Conversation

jamiezieziula
Copy link
Contributor

@jamiezieziula jamiezieziula commented Sep 19, 2022

This PR rebuilds the prefect-agent chart using bitnamis common as its base.

Related to #44

@jamiezieziula jamiezieziula requested review from gabcoyne, zanieb and a team as code owners September 19, 2022 15:00
@jamiezieziula jamiezieziula added enhancement An improvement of an existing feature breaking labels Sep 19, 2022
charts/prefect-agent/Chart.yaml Show resolved Hide resolved
charts/prefect-agent/Chart.yaml Show resolved Hide resolved
@@ -1 +1 @@
1. Check Prefect agent connections in the prefect UI at {{ .Values.config.apiUrl }}
1. Check Prefect agent connections in the prefect UI at {{ .Values.agent.config.apiUrl }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't need to be in this PR, but should we have a more comprehensive notes file, since this is shown whenever helm install or helm upgrade finishes?

charts/prefect-agent/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/prefect-agent/values.yaml Show resolved Hide resolved
@@ -80,7 +80,7 @@ postgresql:
# when using the Postgres database included in the chart.
# For an external postgres connection, you must create
# and use `existingSecret` instead of `postgresqlPassword`.
# password: "HEREWEGO"
password: ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncommenting this by default to grant it better visibility

jawnsy
jawnsy previously approved these changes Sep 19, 2022
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jamiezieziula
Copy link
Contributor Author

FYI relevant kube lint flagged issues below. Unfortunately we cannot set container security context as the prefect image expects the agent to run as the root user, otherwise it is unable to create the /.prefect directory & access other relevant directories like /opt/prefect cc: @madkinsz

KubeLinter 0.5.0

agent.yaml: (object: test-helm/prefect-agent apps/v1, Kind=Deployment) container "prefect-agent" does not have a read-only root file system (check: no-read-only-root-fs, remediation: Set readOnlyRootFilesystem to true in the container securityContext.)

agent.yaml: (object: test-helm/prefect-agent apps/v1, Kind=Deployment) container "prefect-agent" is not set to runAsNonRoot (check: run-as-non-root, remediation: Set runAsUser to a non-zero number and runAsNonRoot to true in your pod or container securityContext. Refer to https://kubernetes.io/docs/tasks/configure-pod-container/security-context/ for details.)

agent.yaml: (object: test-helm/prefect-agent apps/v1, Kind=Deployment) container "prefect-agent" has cpu request 0 (check: unset-cpu-requirements, remediation: Set CPU requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

agent.yaml: (object: test-helm/prefect-agent apps/v1, Kind=Deployment) container "prefect-agent" has cpu limit 0 (check: unset-cpu-requirements, remediation: Set CPU requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

agent.yaml: (object: test-helm/prefect-agent apps/v1, Kind=Deployment) container "prefect-agent" has memory request 0 (check: unset-memory-requirements, remediation: Set memory requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

agent.yaml: (object: test-helm/prefect-agent apps/v1, Kind=Deployment) container "prefect-agent" has memory limit 0 (check: unset-memory-requirements, remediation: Set memory requests and limits for your container based on its requirements. Refer to https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#requests-and-limits for details.)

parkedwards
parkedwards previously approved these changes Sep 20, 2022
@jamiezieziula jamiezieziula merged commit b6f3f60 into main Sep 21, 2022
@jamiezieziula jamiezieziula deleted the chart-overhaul branch September 21, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement An improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants