Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo when checking the support for ingress classname in orion #61

Merged

Conversation

john-jam
Copy link
Contributor

When installing the orion chart with ingress.className defined, the following error occurs:

Error: template: prefect-orion/templates/ingress.yaml:23:51: executing "prefect-orion/templates/ingress.yaml" at <include "common.ingress.supportsIngressClassName" .>: error calling include: template: no template "common.ingress.supportsIngressClassName" associated with template "gotpl"

I think there's a typo in the helper call since it's a lower n in the bitnami/common documentation: https://artifacthub.io/packages/helm/bitnami/common/2.0.2#ingress

@john-jam john-jam requested review from gabcoyne, zanieb and a team as code owners September 23, 2022 01:18
@jamiezieziula jamiezieziula added the fix A fix for a bug in an existing feature label Sep 23, 2022
Copy link
Contributor

@jamiezieziula jamiezieziula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@jamiezieziula jamiezieziula merged commit 92ca848 into PrefectHQ:main Sep 23, 2022
@john-jam john-jam deleted the bugfix/ingress-classname-support-typo branch September 23, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants