-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Comments module displays raw JSON instead of updating the DOM #36093
Comments
@spanishsnapper This bug comes from my recent implementation for @jak78 request make rating mandatory. If you use a theme with override module template (like hummingbird for example), you need add these two lines (inside
at the very top of your theme's |
That fixed it - Thank you @leemyongpakva |
@leemyongpakva thanks for implementing my suggestion. I use the classic theme version 2.1.1, there is no module template override, but I have the issue. Is there a workaround? I'd love to help solve the issue but I'm a beginner: feel free to provide me with instructions. |
@jak78 I think it was a cache issue in your case. You can try CONFIGURE > Advanced Parameters > Performance > Clear Cache in Back-Office, and Clear browser cache in Front-Office. |
Thanks. I just cleared the cache on the back office (do you mean the Smarty
cache?) and the browser cache, but the issue still persists.
Le lun. 13 mai 2024 à 07:51, Lee Pak ***@***.***> a écrit :
… @jak78 <https://github.com/jak78> I think it was a cache issue in your
case. You can try CONFIGURE > Advanced Parameters > Performance > Clear
Cache in Back-Office, and Clear browser cache in Front-Office.
—
Reply to this email directly, view it on GitHub
<#36093 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACV4HP3DKPIZ7ZKKTJSPNLZCBIHTAVCNFSM6AAAAABHGHHTUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWG4YDMMJZGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yes, we usually call it Smarty cache. I see you use Classic theme but with its child_classic also. If you have no module template override in your child_classic theme, then I only have one solution left for you (: copy |
@jak78 I see your site is en françias. |
Thanks @leemyongpakva - I've just done that, then cleaned the Smarty cache and the browser cache, but the issue persists. |
@leemyongpakva I've figured out the issue 🎉 |
I guess there would be some escaping to implement in the module |
@jak78 Great, we still need some improvements on this feature. |
@jak78 , I can't reproduce your issue on my end : Screen.Recording.2024-05-15.at.14.56.01.movI'm using productcomments v7.0.0, PS 8.1.5 and PHP 8.1.13. @leemyongpakva , does this issue needs a PR ? Should I keep it open ? Thanks! |
@florine2623 did you try to use a |
@florine2623 Yes, this issue really a need a PR to solve escaping for special character in JS message variables (jak78 case) and 3rd party themes that have its own productcomments template override (spanishsnapper case). |
@jak78 Is |
@leemyongpakva the French translation string for 'Please choose a rating for your review.' is missing from the productcomments module translation. I had to customize the string to ensure that the text is displayed in French. My French translation contains a |
Hello @jak78 , I tested with the ![]() ![]() |
Hello @jak78, Since we had no news from you for more than 20 days, I'll close this ticket to avoid cluttering up the backlog. Please note that you can always create a new one if further information pops up. Thank you |
Prerequisites
Describe the bug and add attachments
When I submit the form to submit a product comment using the native Prestashop Product Comments module, the raw JSON is displayed. Feel free to watch the enclosed screen recording.
The behavior is the same wether the form submission is an error (error message) or a success (no error message).
I can reproduce the issue on both Chrome (latest version) & Firefox (latest version)
Screen.Recording.2024-05-04.at.00.10.19.mp4
Expected behavior
I would expect the HTML page to be updated instead and display a message to the user.
Steps to reproduce
PrestaShop version(s) where the bug happened
8.1.5
PHP version(s) where the bug happened
8.1.12
If your bug is related to a module, specify its name and its version
product comments 7.0.0
Your company or customer's name goes here (if applicable).
No response
The text was updated successfully, but these errors were encountered: