[ACCOUNT-2723] fix: readonly bo login flag #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hschoenenberger
changed the title
hschoenenberger
changed the title
hschoenenberger
changed the title
hschoenenberger
changed the title
hschoenenberger
commented
Oct 2, 2024
hschoenenberger
changed the title
hschoenenberger
changed the title
hschoenenberger
changed the title
|
jokesterfr
reviewed
Oct 24, 2024
| // /** @var PsAccountsService $service */ | ||
| // $service = $this->module->getService(PsAccountsService::class); | ||
| // $service->enableLogin(true); | ||
| // if ($this->module->isShopEdition()) { |
There was a problem hiding this comment.
Can we remove the "isShopEdition()" method? I would prefer an implementation focusing on our business rather than other teams' products ;)
There was a problem hiding this comment.
We need to go further in that direction but we still use it to trigger segment events...
jokesterfr
approved these changes
Oct 24, 2024
ervinpresta
pushed a commit
that referenced
this pull request
Oct 30, 2024
* feat: don't modify login flag
SD1982
pushed a commit
that referenced
this pull request
Nov 19, 2024
* feat: don't modify login flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://forge.prestashop.com/browse/ACCOUNT-2723