Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker setup #74

Merged
merged 4 commits into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .dockerignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.git
.env
node_modules
config.json
certs
src/logs
dist
logs
uploads
47 changes: 47 additions & 0 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Build and Publish Docker Image

on:
push:
pull_request:
workflow_dispatch:

jobs:
build-publish:
env:
SHOULD_PUSH_IMAGE: ${{ (github.event_name == 'push' && (github.ref == 'refs/heads/master' || github.ref == 'refs/heads/dev')) || github.event_name == 'workflow_dispatch' }}
runs-on: ubuntu-latest

steps:
- name: Set up QEMU for Docker
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Log into the Docker container registry
if: ${{ env.SHOULD_PUSH_IMAGE == 'true' }}
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Extract Docker metadata
id: meta
uses: docker/metadata-action@v5
with:
images: ${{ github.repository }}
tags: |
type=raw,value=latest,enable=${{ github.ref == 'refs/heads/master' }}
type=raw,value=edge,enable=${{ github.ref == 'refs/heads/dev' }}
type=sha

- name: Build and push Docker image
id: build-and-push
uses: docker/build-push-action@v6
with:
platforms: linux/amd64,linux/arm64
push: ${{ env.SHOULD_PUSH_IMAGE }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=gha
cache-to: type=gha,mode=max
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ node_modules
config.json
certs
src/logs
uploads
55 changes: 46 additions & 9 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,52 @@
FROM node:18-alpine
# syntax=docker/dockerfile:1

RUN apk add --no-cache python3 make gcc g++
WORKDIR /app
ARG app_dir="/home/node/app"

COPY "docker/entrypoint.sh" ./

COPY package*.json ./
RUN npm install
# * Base Node.js image
FROM node:20-alpine AS base
ARG app_dir
WORKDIR ${app_dir}

COPY . ./

VOLUME [ "/app/config.json", "/app/certs" ]
# * Installing production dependencies
FROM base AS dependencies

CMD ["sh", "entrypoint.sh"]
RUN --mount=type=bind,source=package.json,target=package.json \
--mount=type=bind,source=package-lock.json,target=package-lock.json \
--mount=type=cache,target=/root/.npm \
npm ci --omit=dev


# * Installing development dependencies and building the application
FROM base AS build

RUN --mount=type=bind,source=package.json,target=package.json \
--mount=type=bind,source=package-lock.json,target=package-lock.json \
--mount=type=cache,target=/root/.npm \
npm ci

COPY . .
# TODO: re-enable after TypeScript migration
#RUN npm run build


# * Running the final application
FROM base AS final
ARG app_dir

RUN mkdir -p ${app_dir}/src/logs && chown node:node ${app_dir}/src/logs \
&& mkdir -p ${app_dir}/uploads && chown node:node ${app_dir}/uploads

ENV NODE_ENV=production
USER node

COPY package.json .

COPY --from=dependencies ${app_dir}/node_modules ${app_dir}/node_modules
COPY --from=build ${app_dir} ${app_dir}

# TODO: change back after TypeScript migration
#COPY --from=build ${app_dir}/dist ${app_dir}/dist

CMD ["node", "."]
12 changes: 0 additions & 12 deletions docker/entrypoint.sh

This file was deleted.

4 changes: 3 additions & 1 deletion src/redisCache.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ const logger = require('./logger');
const config = require('../config.json');
const { host, port } = config.redis;

const redisClient = redis.createClient({ host, port });
const redisClient = redis.createClient({
url: `redis://${host}:${port}`
});

redisClient.on('error', (error) => {
logger.error(error);
Expand Down
4 changes: 4 additions & 0 deletions src/server.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
/* eslint-disable @typescript-eslint/explicit-function-return-type */
/* eslint-disable @typescript-eslint/no-var-requires */
process.title = 'Pretendo - Juxt-Web';
process.on('SIGTERM', () => {
process.exit(0);
});

const express = require('express');
const morgan = require('morgan');
const cookieParser = require('cookie-parser');
Expand Down