Add One Dark theme #130
Merged
Add One Dark theme #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've created a theme based on Atom's lovely One Dark Syntax. The typeface selection is based firstly on the typeface that was used in the screenshot in the earlier link, Fira Mono (but with the open source Fira Code given priority), followed by the default selection of typefaces in Atom itself.
I might have gone overboard adding overrides for HTML, CSS, JS, JSON, and Markdown so I could match Atom as much as possible (I gave up eventually), let me know if I should remove them!
As a side note, One Dark is slightly different from One Dark Pro, so it does not quite close the existing issue on adding One Dark Pro. But considering that the differences are really minor, there is no real difference to me, and I will let someone else decide whether #100 ought to be considered resolved.
In addition, I also fixed a link in the README that was pointing to the wrong theme.
Thanks!