PHP: Fix shell-comment failure now that strings are greedy

PrismJS · Mar 3, 2018 · ad25d22 · ad25d22
1 parent 5d7223c
commit ad25d22
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 17 deletions.
diff --git a/components/prism-php.js b/components/prism-php.js
@@ -20,9 +20,7 @@ Prism.languages.php = Prism.languages.extend('clike', {
 	}
 });
 
-// Shell-like comments are matched after strings, because they are less
-// common than strings containing hashes...
-Prism.languages.insertBefore('php', 'class-name', {
+Prism.languages.insertBefore('php', 'string', {
 	'shell-comment': {
 		pattern: /(^|[^\\])#.*/,
 		lookbehind: true,

diff --git a/components/prism-php.min.js b/components/prism-php.min.js
diff --git a/examples/prism-php.html b/examples/prism-php.html
@@ -67,16 +67,4 @@ <h2>String interpolation</h2>
 FOO;
 $b = &lt;&lt;&lt;"FOOBAR"
     Interpolation inside Heredoc strings {$obj->values[3]->name}
-FOOBAR;</code></pre>
-
-<h2>Known failures</h2>
-<p>There are certain edge cases where Prism will fail.
-	There are always such cases in every regex-based syntax highlighter.
-	However, Prism dares to be open and honest about them.
-	If a failure is listed here, it doesn’t mean it will never be fixed. This is more of a “known bugs” list, just with a certain type of bug.
-</p>
-
-<h3>Shell-like comments containing two quotes of the same type</h3>
-<pre><code># Shell-like comment "with quotes" inside
-# Shell-like comment 'with quotes' inside</code></pre>
-
+FOOBAR;</code></pre>