Markup: Fixed quotes in HTML attribute values (#3442)

PrismJS · Apr 29, 2022 · ca8eaee · ca8eaee
1 parent 0d4b6cb
commit ca8eaee
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 7 deletions.
diff --git a/components/prism-markup.js b/components/prism-markup.js
@@ -51,7 +51,10 @@ Prism.languages.markup = {
 							pattern: /^=/,
 							alias: 'attr-equals'
 						},
-						/"|'/
+						{
+							pattern: /^(\s*)["']|["']$/,
+							lookbehind: true
+						}
 					]
 				}
 			},

diff --git a/components/prism-markup.min.js b/components/prism-markup.min.js
diff --git a/prism.js b/prism.js
@@ -1325,7 +1325,10 @@ Prism.languages.markup = {
 							pattern: /^=/,
 							alias: 'attr-equals'
 						},
-						/"|'/
+						{
+							pattern: /^(\s*)["']|["']$/,
+							lookbehind: true
+						}
 					]
 				}
 			},

diff --git a/tests/languages/markup!+javascript/javascript_inclusion.test b/tests/languages/markup!+javascript/javascript_inclusion.test
@@ -143,10 +143,7 @@ let foo = '</script>';
 		["attr-value", [
 			["punctuation", "="],
 			["punctuation", "\""],
-			"this.textContent=",
-			["punctuation", "'"],
-			"Over!",
-			["punctuation", "'"],
+			"this.textContent='Over!'",
 			["punctuation", "\""]
 		]],
 		["punctuation", ">"]

diff --git a/tests/languages/markup/issue3441.test b/tests/languages/markup/issue3441.test
@@ -0,0 +1,27 @@
+<google-chart data='[["Month", "Days"], ["Jan", 31]]'></google-chart>
+
+----------------------------------------------------
+
+[
+	["tag", [
+		["tag", [
+			["punctuation", "<"],
+			"google-chart"
+		]],
+		["attr-name", ["data"]],
+		["attr-value", [
+			["punctuation", "="],
+			["punctuation", "'"],
+			"[[\"Month\", \"Days\"], [\"Jan\", 31]]",
+			["punctuation", "'"]
+		]],
+		["punctuation", ">"]
+	]],
+	["tag", [
+		["tag", [
+			["punctuation", "</"],
+			"google-chart"
+		]],
+		["punctuation", ">"]
+	]]
+]