Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.npmignore: Unignore components.js #1108

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

papandreou
Copy link
Contributor

For the trick suggested by @apfelbox in #593 (comment) to work, we need both of these files to be in the NPM package:

  • /components.js
  • /tests/helper/components.js

For the trick suggested by @apfelbox in
PrismJS#593 (comment)
to work, we need both of these files to be in the NPM package:

/components.js
/tests/helper/components.js
papandreou added a commit to unexpectedjs/magicpen-prism that referenced this pull request Mar 9, 2017
@LeaVerou LeaVerou merged commit 1f699e7 into PrismJS:gh-pages Mar 9, 2017
@LeaVerou
Copy link
Member

LeaVerou commented Mar 9, 2017

Thanks!

PS: Nice username :P

@papandreou
Copy link
Contributor Author

Thanks :)

PS: Nice username :P

That's not the usual reaction from Greeks! (eg. less/less.js#462 (comment))

@LeaVerou
Copy link
Member

LeaVerou commented Mar 9, 2017

That's not the usual reaction from Greeks!

Haha, I thought you chose it ironically :) Also that dude seriously needs to chill, geez.

@papandreou
Copy link
Contributor Author

I thought you chose it ironically

It's actually been with me since I was a kid. My name is Andreas and my parents thought that "Andreas Papandreou" sounded cute. Seemed innocent enough until those real Papandreous got into all those scandals and bankrupted the country ;)

@LeaVerou
Copy link
Member

Seemed innocent enough until those real Papandreous got into all those scandals and bankrupted the country ;)

True, though they also passed many laws to bring the country up to date with other developed countries, such as the gender equality laws of 1983, or civil marriage in 1982. I dislike PASOK as much as the next person, but they did some good things too, για να λέμε και του στραβού το δίκιο :)

@Golmote Golmote mentioned this pull request Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants