Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTML entities in attribute values #1143

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Support HTML entities in attribute values #1143

merged 2 commits into from
Jun 5, 2017

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Jun 3, 2017

prism-attr-entity

@LeaVerou
Copy link
Member

LeaVerou commented Jun 4, 2017

Thanks for contributing!
However, we tend to avoid duplicating expressions, and instead prefer to point to them by reference. This way, they will always be in sync. You could add a line under the language definition that does this.

PS: Nice theme! Yours?

@valtlai
Copy link
Contributor Author

valtlai commented Jun 4, 2017 •
edited
Loading

Done.

Yeah, it’s mine. Most of the colors are from Chrome DevTools’ material colors palette.

@LeaVerou LeaVerou merged commit 1d5047d into PrismJS:gh-pages Jun 5, 2017
@LeaVerou
Copy link
Member

LeaVerou commented Jun 5, 2017

Merged, thanks!

Please consider releasing the theme somewhere, it's gorgeous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valtlai @LeaVerou