Check if tokens exists and return #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the language was autoloaded, the grammar may not exist yet. We need to check if it exists before we attempt to modify it.
mAAdhaTTah
force-pushed
the
bugfix/show-invisibles-missing-grammar
branch
from
f6f3ab5
to
e62ebca
Compare
mAAdhaTTah
referenced
this pull request
Sep 27, 2017
|
@Golmote All of the plugins except this one check the existence of grammar first. This PR is good to go. Can you merge this tomorrow? #hacktoberfest |
|
I don't think I'll have time for Prism until next weekend. This PR is on my to-check list though |
mAAdhaTTah
added a commit
to intraxia/wp-gistpen
that referenced
this pull request
Sep 30, 2017
Waiting for PrismJS/prism#1195 to land.
mAAdhaTTah
added a commit
to intraxia/wp-gistpen
that referenced
this pull request
Sep 30, 2017
Waiting for PrismJS/prism#1195 to land.
mAAdhaTTah
added a commit
to intraxia/wp-gistpen
that referenced
this pull request
Oct 1, 2017
Waiting for PrismJS/prism#1195 to land.
mAAdhaTTah
added a commit
to intraxia/wp-gistpen
that referenced
this pull request
Oct 1, 2017
Waiting for PrismJS/prism#1195 to land.
mAAdhaTTah
added a commit
to intraxia/wp-gistpen
that referenced
this pull request
Oct 1, 2017
Waiting for PrismJS/prism#1195 to land.
|
Ok, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the language was autoloaded, the grammar may not exist yet.
We need to check if it exists before we attempt to modify it.
See here for details: 70cb472