Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescaped markup plugin: Make it work with any language #1265

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

Golmote
Copy link
Contributor

@Golmote Golmote commented Jan 16, 2018

This PR fixes #1262.
It also follows with what was initially said in #892.
@LeaVerou and @zeitgeist87, could you have a quick look? I can't think of any real issue here, but just to be sure.

@zeitgeist87
Copy link
Collaborator

Looks good to me. I can't think of any situation where it would be harmful to allow it for other languages.

@LeaVerou
Copy link
Member

Can't see why it's useful for other languages, but can't see any harm either.
I guess other languages exist that have a lot of angle brackets?

@Golmote
Copy link
Contributor Author

Golmote commented Jan 17, 2018

@LeaVerou, @zeitgeist87, thanks!
Yes, there are definitely languages using angle brackets out there. First of all, languages that work with HTML, such as PHP, ASP, Handlebars, Smarty, Twig, JSX, Markdown, Textile, etc. Also, Wiki markup, syntaxes like vector<int> in C++ that are quite common, or even s<foo><bar> in Perl... and probably other use cases I can't think of. There is a real need for this. :)

@Golmote Golmote merged commit 7bcdae7 into PrismJS:gh-pages Jan 17, 2018
@iwasherefirst2
Copy link

Thank you! That is a great feature!

@Golmote Golmote deleted the unescaped-markup-generic branch January 17, 2018 22:40
@LeaVerou
Copy link
Member

@Golmote Thanks for doing this then!!

papandreou added a commit to papandreou/prism that referenced this pull request Jan 29, 2018
* gh-pages: (326 commits)
  Add C++ platform-independent types (PrismJS#1271)
  Release 1.10.0
  Unescaped markup plugin: Make it work with any language (PrismJS#1265)
  Previewers: New plugin combining previous plugins Previewer: Base, Previewer: Angle, Previewer: Color, Previewer: Easing, Previewer: Gradient and Previewer: Time. Fix PrismJS#913 (PrismJS#1244)
  Add Elm (elm-lang.org) support (PrismJS#1174)
  IchigoJam: Remove unneeded escape
  Run gulp
  add Io syntax (PrismJS#1251)
  package.json: add attribute `style` (PrismJS#1256)
  Add the C++11 raw string feature to the cpp language
  IchigoJam: Make strings greedy
  BASIC: Make strings greedy
  Run gulp
  Add support for IchigoJam BASIC (PrismJS#1246)
  Add support for 6502 assembly (PrismJS#1245)
  fix for autoloader plugin
  Run gulp and reorder components alphabetically
  Xeora Language implementation (PrismJS#1239)
  upgrade autoloader
  Release 1.9.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants