Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .npmignore #1274

Closed
wants to merge 1 commit into from
Closed

Update .npmignore #1274

wants to merge 1 commit into from

Conversation

evanplaice
Copy link

Trim the fat on the prism.js npm package.

Ignore:
tests/ - not necessary for production
.tgz - used while testing packages w/ npm pack
bower.json - not necessary in a NPM package
composer.json - not necessary in a NPM package
components.js - used internally
examples.js - used internally
gulpfile.js - used for dev only
.editorconfig - used for dev only
.gitattributes - used for dev only
.travis.yml - used for dev only

Trim the fat on the prism.js npm package.

Ignore:
tests/ - not necessary for production
.tgz - used while testing packages w/ `npm pack`
bower.json - not necessary in a NPM package
composer.json - not necessary in a NPM package
components.js - used internally
examples.js - used internally
gulpfile.js - used for dev only
.editorconfig - used for dev only
.gitattributes - used for dev only
.travis.yml - used for dev only
@Golmote
Copy link
Contributor

Golmote commented Jan 31, 2018

Hi! Thanks for contributing.

The only one I'm "worried" about is components.js. It is the only file that currently holds the information on which component depends on which other component. And we do know that some users might rely on it to get the list of dependencies.

There was an explicit request for this in #1108 (this specific issue was also asking for the /tests/helper/components.js file, so we should not ignore this one too).

@evanplaice
Copy link
Author

OK. I'll update the PR as soon as I get back to my computer.

@Golmote Golmote closed this in a52319a Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants