Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescaped Plugin breaks js, and works incorrectly in IE & Edge #1302

Closed
aaronstezycki opened this issue Feb 20, 2018 · 3 comments
Closed

Unescaped Plugin breaks js, and works incorrectly in IE & Edge #1302

aaronstezycki opened this issue Feb 20, 2018 · 3 comments

Comments

@aaronstezycki
Copy link

aaronstezycki commented Feb 20, 2018

Using the plugin to generate some pug/jade content using the unescaped plugin.

When viewing the output on Mac OS Safari, Chrome etc the plugin works fine. However when viewing the page on Windows 10, (or lower) in IE and Edge gives a console error and breaks js on the page.

It seems to fall over element.matches. :

screen shot 2018-02-20 at 09 35 40

screen shot 2018-02-20 at 09 31 35

Unsure exactly why it's falling over, as I've discovered that Edge supports matches().
https://caniuse.com/#search=matches

¯_(ツ)_/¯

@Golmote
Copy link
Contributor

Golmote commented Feb 20, 2018

Hi! I could not reproduce your issue on Edge 16.
But I reproduced it in IE11 and lower, where matches is not supported in its unprefixed form. We should probably use msMatchesSelector as a fallback for those browsers (IE9-11).

@aaronstezycki
Copy link
Author

Hi @Golmote, was this issue fixed and a PR merged? I could do with this plugin working for IE. Sorry if it has 👍

@Golmote
Copy link
Contributor

Golmote commented Mar 5, 2018

Hi! I fixed it in a direct commit (not a PR). It should work properly on gh-pages and I'll make an official release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants