TOML support #1488
Merged
TOML support #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
requested changes
Jul 21, 2018
|
Test were added. I'm looking forward to the review. |
|
Isn't the label supposed to be |
|
Yeah, switched to needs review. |
|
How it is going, I am quite looking forward to this feature. |
|
@johng-cn |
mAAdhaTTah
approved these changes
Sep 22, 2018
|
If we get the conflicts resolved, we can merge this. |
|
Thanks, @RunDevelopment! |
ggrossetie
pushed a commit
to ggrossetie/prism
that referenced
this pull request
Mar 11, 2019
Add support for [Tom's Obvious, Minimal Language](https://github.com/toml-lang/toml). Some simplifications: 1. The `.`s of dotted keys are not highlighted. This is because the `.` could be inside quotes and checking that isn't easy. 2. There is no distinction between table `[foo]` and array `[[foo]]`. `foo` will be highlighted as `table` in both cases.
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Tom's Obvious, Minimal Language.
I made some simplifications:
.s of dotted keys are not highlighted. This is because the.could be inside quotes and checking that isn't easy.[foo]and array[[foo]].foowill be highlighted astablein both cases.This PR resolves #1436