Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insertBefore should check that before exists #1717

Closed
RunDevelopment opened this issue Jan 24, 2019 · 2 comments · Fixed by #1803
Closed

insertBefore should check that before exists #1717

RunDevelopment opened this issue Jan 24, 2019 · 2 comments · Fixed by #1803
Labels
enhancement

Comments

@RunDevelopment
Copy link
Member

Details
@mAAdhaTTah
Copy link
Member

Summary:

The issue I had is shipping code to users that will never execute if the languages are coded up correctly.

Potential suggestions:

  1. ESLint plugin to make sure those values are valid.
  2. External test to validate param exists.

@ExE-Boss
Copy link
Contributor

ExE-Boss commented Feb 13, 2019 •
edited
Loading

I think it should print a warning or an error in the development console.

And cause the PrismJS build to fail by enabling a config setting to have inserBefore calls that fail cause the whole build to fail.

@RunDevelopment RunDevelopment mentioned this issue Mar 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests: Additional checks for Prism functions RunDevelopment/prism
3 participants
@ExE-Boss @mAAdhaTTah @RunDevelopment