Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm: Fixed test script #1809

Merged
merged 5 commits into from
Mar 14, 2019
Merged

Conversation

RunDevelopment
Copy link
Member

Because of #1646 the command mocha tests/run.js was no longer the last command in the chain which means that arguments like npm test -- --language=css were not passed to it.
This fixes the issue.

package.json Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member Author

RunDevelopment commented Mar 14, 2019

Like this @mAAdhaTTah ?
This, of course, has the disadvantage that none of the arguments of npm test are passed to either of the called commands.

Note to self: Don't forget to adjust the docs.

@mAAdhaTTah
Copy link
Member

@RunDevelopment Yeah, that's what I was thinking. If you're just testing a single language, you wouldn't run the main command, you'd just run npm run test:languages with the appropriate flag. You wouldn't want to run all the other tests at the same time.

package.json Outdated Show resolved Hide resolved
Co-Authored-By: RunDevelopment <mitchi5000.ms@googlemail.com>
@RunDevelopment
Copy link
Member Author

Alright, then I'll adjust the docs and then this should be gtg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants