-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for JavaScript octal and binary numbers (in ES6) #597
Conversation
You can merge #596 before this one, so I can rebase my PR based on these javascript changes. |
I just merged #596. Let me know when this PR is updated. |
So, i just rebased and squashed the changes in one commit. Ready to be merged @Golmote |
Sorry, can you do it again? |
They are supported from ES6+
@Golmote no problem, done. |
Support for JavaScript octal and binary numbers (in ES6)
Hey @vkbansal, maybe I'm wrong, but it doesn't look like operators are highlighted as part of numbers with Prism currently: So it would seem to fall in line that Totally let me know if I'm missing something, though! |
@vkbansal @loganfranken even easier than that. If you take a closer look at the braces in the regex, you will see that only @loganfranken you are right, the regex matches it, but it isn't included in the token. Because of this it will be highlighted as operator later on. |
@apfelbox Ahh, thanks for clearing that up! |
@apfelbox thanks for the clarification :) |
This will add support octal and binary numbers:
I also removed a duplicate negative sign for
Infinity
.Fixes part of #111