Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keyman language highlighting #609

Merged
merged 6 commits into from
Jun 28, 2015
Merged

Add Keyman language highlighting #609

merged 6 commits into from
Jun 28, 2015

Conversation

mcdurdin
Copy link
Contributor

Adds Keyman / KMFL language highlighting, as documented at http://help.keyman.com/developer/9.0/docs/

@@ -0,0 +1,14 @@
Prism.languages.keyman = {
'comment': /\b[cC]\s.*?(\r?\n|$)/,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simplify the regexp by using the i flag.
Also, I think you can remove the last part ?(\r?\n|$) since the dot . does not match line feeds. (Unless you intentionally wanted to consume the line feed?)

@Golmote
Copy link
Contributor

Golmote commented Jun 27, 2015

Thanks for contributing. Please take a look at my comments.

@mcdurdin
Copy link
Contributor Author

Thanks for the deep review. I think all comments addressed, a couple of extra minor tweaks as well.

@Golmote
Copy link
Contributor

Golmote commented Jun 27, 2015

Thanks, this looks good to me now.
@LeaVerou what do you think?

LeaVerou added a commit that referenced this pull request Jun 28, 2015
Add Keyman language highlighting
@LeaVerou LeaVerou merged commit 2698f82 into PrismJS:gh-pages Jun 28, 2015
@LeaVerou
Copy link
Member

Merged, thank you both!

@mcdurdin
Copy link
Contributor Author

Thank you both as well -- that's how a pull request should always work :) Smooth as.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants