Substantially reduce wrongly highlighted stuff for Bash #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keywords and functions should not start with a boundary character, because this leads to lots of false matches. Bash actually only allows a few boundary characters for commands and functions. This patch replaces the \b with an explicit list of allowed characters. This improves the highlighting of pathnames enourmously. Some examples of invalid highlighting this patch fixes: cat /etc/passwd cat ./if/else/something-file.txt This patch also adds the built-in commands ":" and ".". : NOOP-command . Source command
Currently arithmetic operators are wrongly matched all over the place. For example the dash in `ls -la` is highlighted as a minus operator, but for Bash it is only a string. Another example would be a simple path like this `cat 801-file.txt`. Here `801` is wrongly highlighted as a number and `-` is highlighted as an operator. Bash only supports numbers and arithmetic operators inside of a so called arithemtic environment `$((3 + 4))`. By supporting this and limiting numbers and arithmetic operators to arithemtic environments, a lot of wrongly highlighted stuff can be avoided.
Command substitution is a very important part of the Bash language. Every non trivial script uses it in one way or another. This patch adds support for it.
Golmote
added a commit
that referenced
this pull request
Oct 6, 2015
Substantially reduce wrongly highlighted stuff for Bash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set contains not only two new features for Bash (namely arithmetic environments and command substitutions), but it uses these features to fix a lot of the annoying stuff about Bash highlighting.
The following simple example should illustrate what I mean:
Here
104is highlighted as a number,-as an operator,fileas a function and.as punctuation. All of these things are wrong, because Bash interprets this as the string"104-file.txt".In Bash numbers and arithmetic operations can only exist in arithmetic environments and everything outside of an arithmetic environment is interpreted as a string:
$((5 + 6))Also keywords and functions can only have certain characters surrounding them namely
/(^|\s|;|\||&)/. In any other context it is just a string.This patch set fixes all of the above and adds support for command substitution. I also added tests for all of the new features.
The result looks like this: