Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose unminified JS files in the jspm config? #995

Closed
diagramatics opened this issue Jul 5, 2016 · 3 comments
Closed

Expose unminified JS files in the jspm config? #995

diagramatics opened this issue Jul 5, 2016 · 3 comments

Comments

@diagramatics
Copy link

Hi there. I'm not sure about the decision to expose the JS files in components as minified files in JSPM.

"jspm": {
    "main": "prism",
    "registry": "jspm",
    "jspmPackage": true,
    "format": "global",
    "files": [
      "components/**/*.min.js",
      "plugins/**/*",
      "themes/*.css",
      "prism.js"
    ]
}

Considering that JSPM is often used alongside the SystemJS module bundler, which takes care of minification as well, this could cause issues like a difficult source to read. I know Bower adopts this approach of exposing an unminified code for the sake of giving developers the control they might need, and I'm pretty sure this approach can be applied here.

Happy to make a PR if there's an agreement. Thanks in advance!

@Golmote
Copy link
Contributor

Golmote commented Apr 5, 2018

@eriklieben, since you originally added special configuration for JSPM, do you have any opinion on this?

@eriklieben
Copy link
Contributor

I must honestly say that I haven't been using JSPM/SystemJS in the last year or so and that knowledge faded away. It sounds like a good thing to do, so the dev using it is in charge of the way to do minification to the files.

@Golmote Golmote closed this as completed in 218f160 Apr 6, 2018
@Golmote
Copy link
Contributor

Golmote commented Apr 6, 2018

@eriklieben Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants