1.21.4 #33
Open
1.21.4 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the error ? Shouldn't we fix it ? |
|
Lots of errors like this but with different items: The 1.21.4 jar is missing a lot of item models for some reason. |
|
Probably they're in a different location, can you check the new folder
structure?
…On Wed, Jan 22, 2025, 06:58 SuperGamerTron ***@***.***> wrote:
Lots of errors like this but with different items:
Error: ENOENT: no such file or directory, open 'D:\PrismarineJS\minecraft-jar-extractor\temp/1.21.4/assets/minecraft/models/item/vault.json'
at Object.openSync (node:fs:596:3)
at Object.readFileSync (node:fs:464:35)
at extractModel (D:\PrismarineJS\minecraft-jar-extractor\image_names.js:232:31)
at D:\PrismarineJS\minecraft-jar-extractor\image_names.js:255:21
at Array.map (<anonymous>)
at getItems (D:\PrismarineJS\minecraft-jar-extractor\image_names.js:253:42)
at D:\PrismarineJS\minecraft-jar-extractor\image_names.js:330:5
at D:\PrismarineJS\minecraft-jar-extractor\get_minecraft_files.js:16:7
The 1.21.4 jar is missing a lot of item models for some reason.
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR437QCWKV4HAKSTX5FGHL2L4XPFAVCNFSM6AAAAABVTUV5SOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBWGM3DENZYGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
The folder structure has indeed been changed. Some models have been moved or added into a new folder. |
|
Ok let's add a if version more than 1.21.4 and point to the new folder in the script |
|
let's finish it ? |
|
It's ready. The new folder uses a different model format, I'll make a pr in the jar extractor. |
|
please do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jar extractor is currently failing to generate item models for 1.21.4.